Review Request 126809: Allow to rotate the page view using two-finger pinches on a touchscreen
Oliver Sander
oliver.sander at tu-dresden.de
Sun Oct 16 09:39:07 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126809/
-----------------------------------------------------------
(Updated Oct. 16, 2016, 9:39 a.m.)
Review request for Okular.
Changes
-------
Rebase to current frameworks branch
Now that pinch-to-zoom support has landed in 'frameworks' (in 9d90a08ef5e22d682a5a5004128f72d1a5a84aff ) some infrastructure code for gesture capturing can be removed.
Repository: okular
Description
-------
With this patch you can rotate pages by touching your touchscreen with two fingers and then rotating the fingers. No fancy animation is implemented; all this patch does is call slotRotate[Counter]Clockwise when
the corresponding Qt gesture is triggered.
Sorry for again posting patches against the 'frameworks' branch. This patch is trivial to backport to the master branch, and as far as I understand Qt, it should work there just the same. Only it doesn't -- no gesture events are ever received. Feel free to ignore this patch until 'frameworks' has been merged into the master branch.
Diffs (updated)
-----
ui/pageview.cpp 339ba69
Diff: https://git.reviewboard.kde.org/r/126809/diff/
Testing
-------
Works on my ThinkPad Yoga 12 with today's Debian testing.
Thanks,
Oliver Sander
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20161016/00fd375a/attachment.html>
More information about the Okular-devel
mailing list