Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

Oliver Sander oliver.sander at tu-dresden.de
Sat Oct 15 13:23:33 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128821/
-----------------------------------------------------------

(Updated Oct. 15, 2016, 1:23 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Changes
-------

Submitted with commit 9d90a08ef5e22d682a5a5004128f72d1a5a84aff by Martin T. H. Sandsmark to branch frameworks.


Bugs: 366781
    http://bugs.kde.org/show_bug.cgi?id=366781


Repository: okular


Description
-------

The attached patch implements document zoom controlled by a two-finger pinch gesture on a touch screen.

The actual zooming was done by copy'n'paste, I don't understand the full details of how zooming works in okular, yet.  So a bit of review would be appreciated.


Diffs
-----

  ui/pageview.h 7c43f51 
  ui/pageview.cpp 5fbabb2 

Diff: https://git.reviewboard.kde.org/r/128821/diff/


Testing
-------

I tested it on my Lenovo Thinkpad Yoga, and it works nicely there.


Thanks,

Oliver Sander

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20161015/bd8a15a8/attachment.html>


More information about the Okular-devel mailing list