Review Request 129099: Make m_drawingEngine a std::unique_ptr

[Oliver Sander]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129099/
-----------------------------------------------------------

(Updated Oct. 7, 2016, 4:31 p.m.)


Status
------

This change has been discarded.


Review request for Okular.


Repository: okular


Description
-------

Because it has ownership semantics.

The code would be even shorter with std::make_unique, but that is C++14.  Is that allowed in Okular?


Diffs
-----

  ui/presentationwidget.h 69574d2 
  ui/presentationwidget.cpp c16d616 

Diff: https://git.reviewboard.kde.org/r/129099/diff/


Testing
-------


Thanks,

Oliver Sander

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20161007/3f97a156/attachment.html>