Review Request 129288: Fix unused computation result warning in plucker

Albert Astals Cid aacid at kde.org
Thu Nov 17 21:30:18 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129288/#review100408
-----------------------------------------------------------



If we don't know what we're doing, let's actually leave the warning there so someone that knows what's happening can fix it properly.

- Albert Astals Cid


On Oct. 30, 2016, 2:29 p.m., Miklós Máté wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129288/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2016, 2:29 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> If we assume that the code was correct, then the pointer dereference is unnecessary. If we assume that the code was wrong, then it probably wanted to do (*font)--. I assumed the former, but I can't test it.
> 
> 
> Diffs
> -----
> 
>   generators/plucker/unpluck/qunpluck.cpp 8363dd3 
> 
> Diff: https://git.reviewboard.kde.org/r/129288/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20161117/d2b52121/attachment.html>


More information about the Okular-devel mailing list