Review Request 124069: Implement a 'Save' menu action (Fixes bug #348642)
Oliver Sander
oliver.sander at tu-dresden.de
Tue Nov 15 10:32:46 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124069/#review100852
-----------------------------------------------------------
part.cpp (line 768)
<https://git.reviewboard.kde.org/r/124069/#comment67680>
No keyboard shortcut is set here. Is that intentional?
- Oliver Sander
On June 11, 2015, 11:03 a.m., Jonathan Verner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124069/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 11:03 a.m.)
>
>
> Review request for Okular.
>
>
> Bugs: 348642
> http://bugs.kde.org/show_bug.cgi?id=348642
>
>
> Repository: okular
>
>
> Description
> -------
>
> Implement a 'Save' menu action to complement the 'Save As...' action.
> The action saves the current document. Note that it uses the Save As
> implementation but does not query the user for a filename instead using
> the document filename.
>
>
> Diffs
> -----
>
> part.h 9eebdb2cd033eaec00ea88b57545721173e745f0
> part.cpp 5b03e56e194bf84a9f02ceaf94cad13526715157
> part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36
>
> Diff: https://git.reviewboard.kde.org/r/124069/diff/
>
>
> Testing
> -------
>
> I ran okular and tested that Ctrl-S as well as the menu action that they work.
>
>
> Thanks,
>
> Jonathan Verner
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20161115/433595e4/attachment-0001.html>
More information about the Okular-devel
mailing list