Review Request 129347: add metadata for kimgio, mobipocket, ooo, plucker, poppler, spectre, txt, xps

[Matthias Klumpp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129347/#review100650
-----------------------------------------------------------




generators/mobipocket/org.kde.okular-mobipocket.metainfo.xml (line 7)
<https://git.reviewboard.kde.org/r/129347/#comment67578>

    This should not also be called "Images", I guess.



generators/ooo/org.kde.okular-ooo.metainfo.xml (line 7)
<https://git.reviewboard.kde.org/r/129347/#comment67579>

    Same here... (probably should be "OpenDocument")



generators/plucker/org.kde.okular-plucker.metainfo.xml (line 7)
<https://git.reviewboard.kde.org/r/129347/#comment67580>

    Etc. - Seems to be duplicated in every file.


- Matthias Klumpp


On Nov. 6, 2016, 10:21 a.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129347/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2016, 10:21 a.m.)
> 
> 
> Review request for Okular and Matthias Klumpp.
> 
> 
> Bugs: 363842
>     http://bugs.kde.org/show_bug.cgi?id=363842
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   generators/kimgio/CMakeLists.txt 9ac7aeb 
>   generators/kimgio/org.kde.okular-kimgio.metainfo.xml PRE-CREATION 
>   generators/mobipocket/CMakeLists.txt 059dd35 
>   generators/mobipocket/org.kde.okular-mobipocket.metainfo.xml PRE-CREATION 
>   generators/ooo/CMakeLists.txt 86726d1 
>   generators/ooo/org.kde.okular-ooo.metainfo.xml PRE-CREATION 
>   generators/plucker/CMakeLists.txt 708f0af 
>   generators/plucker/org.kde.okular-plucker.metainfo.xml PRE-CREATION 
>   generators/poppler/CMakeLists.txt b31c36b 
>   generators/poppler/org.kde.okular-poppler.metainfo.xml PRE-CREATION 
>   generators/spectre/CMakeLists.txt 47fc00f 
>   generators/spectre/org.kde.okular-spectre.metainfo.xml PRE-CREATION 
>   generators/tiff/CMakeLists.txt 31349ec 
>   generators/tiff/org.kde.okular-tiff.metainfo.xml PRE-CREATION 
>   generators/txt/CMakeLists.txt 202a3f9 
>   generators/txt/org.kde.okular-txt.metainfo.xml PRE-CREATION 
>   generators/xps/CMakeLists.txt 32e24d0 
>   generators/xps/org.kde.okular-xps.metainfo.xml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129347/diff/
> 
> 
> Testing
> -------
> 
> verified with appstreamcli validate
> builds + installs
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20161106/439e97c0/attachment.html>