[Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

Aleix Pol Gonzalez aleixpol at kde.org
Mon May 30 22:13:45 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/
-----------------------------------------------------------

(Updated May 31, 2016, 12:13 a.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Changes
-------

Submitted with commit 32b62e919a6493cca9d5d2b272872b53f9b5e41d by Aleix Pol to branch frameworks.


Repository: okular


Description
-------

Drops KDELibs4Support usage, mostly it wasn't actually used, except for that KFileDialog usage that I ported.


Diffs
-----

  shell/shell.cpp c97054a 

Diff: https://git.reviewboard.kde.org/r/127021/diff/


Testing
-------

Opening dialog seems to work fine, tests still pass except for parttest, but I'm unsure it's related: https://paste.kde.org/p37pdubgf


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160530/56d9b9eb/attachment.html>


More information about the Okular-devel mailing list