[Okular-devel] Review Request 127496: Normal right click processing in text selection mode if no text has been selected.

[Jonathan Schultz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127496/
-----------------------------------------------------------

(Updated March 26, 2016, 2:38 a.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Repository: okular


Description
-------

This diff means that a right click in text selection mode when no selection has been made is treated in the same way as in rectangular or table selection mode. That is, rather than receiving no response to a right click, the user typically sees a menu allowing the normal bookmark adding/removing and navigation.

I also tidied up some indentation errors in PageView::mouseReleaseEvent(), which makes it a little difficult to see from the diff what is actually going on. An ignore-whitespace diff (ie with the '-w' option) makes it more obvious. The only non-whitespace change is the section that contains the comment '// If nothing else going on, process right click as normal'


Diffs
-----

  ui/pageview.cpp 3ebf7dc 

Diff: https://git.reviewboard.kde.org/r/127496/diff/


Testing
-------


Thanks,

Jonathan Schultz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160326/53fbc3bd/attachment.html>