[Okular-devel] Review Request 127013: Properly show marker for current section in TOC

[Miklós Máté]

> On March 10, 2016, 12:28 a.m., Albert Astals Cid wrote:
> > This will put triangles in the whole chain of parent, child, child when the list is not a treeview, maybe we can also check somewhere else so that the behaviour does not change when it's not a treeview (i.e. onyl the last one has the triangle)?
> 
> Miklós Máté wrote:
>     Without information about the expanded nodes the best we can do is to put triangles at every containing node. Using only the last node is not good, because it may be hidden within a collapsed parent node.
> 
> Albert Astals Cid wrote:
>     I disagree, please change it so that it behaves as it used to behave if it's not a qtreeview.
> 
> Miklós Máté wrote:
>     Is it acceptable that only the last highlighted node gets a triangle?
> 
> Albert Astals Cid wrote:
>     Not sure I understand what you mean with that

I'll update the patch to show what I mean.


- Miklós


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127013/#review93378
-----------------------------------------------------------


On March 9, 2016, 8:41 p.m., Miklós Máté wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127013/
> -----------------------------------------------------------
> 
> (Updated March 9, 2016, 8:41 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> fixes bug #342076
> 
> 
> Diffs
> -----
> 
>   ui/tocmodel.cpp ce93366 
> 
> Diff: https://git.reviewboard.kde.org/r/127013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160317/11637e0d/attachment.html>