[Okular-devel] Review Request 127351: Added ability to view embedded files

[Daniel Lichtenberger]

> On March 14, 2016, 12:28 a.m., Albert Astals Cid wrote:
> > Could you please fix all the indentation to be like the one in the file?
> 
> Daniel Lichtenberger wrote:
>     ui/embeddedfilesdialog.{h,cpp} use both tabs and spaces (even within the same method). Should I just convert them to spaces-only?

The indentation should now match the style used in the method. For better maintainability it might still be a good idea to switch ui/embeddedfilesdialog completely to Okular's code style (4 spaces per level?).


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127351/#review93500
-----------------------------------------------------------


On March 16, 2016, 4:59 p.m., Daniel Lichtenberger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127351/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 4:59 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 295567
>     http://bugs.kde.org/show_bug.cgi?id=295567
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> The selected embedded file(s) are extracted to QDir::tempPath() and the
> default application associated with the file type is launched with KRun.
> 
> Double-click on an embedded file also launches the view action.
> 
> The temporary files are cleaned up automatically when the dialog is
> closed.
> 
> 
> Diffs
> -----
> 
>   ui/embeddedfilesdialog.h f3e2d038f4ffe2b64af15c94c7ec0cfb8a68834c 
>   ui/embeddedfilesdialog.cpp b400e879b2849a931e069669c984a6b578ffd536 
>   ui/guiutils.h fffe04488b27d92d9a7bc623da653d0c1df87ae8 
>   ui/guiutils.cpp 3bf3ad64b57396792c3aa33298265561ee35ed1a 
> 
> Diff: https://git.reviewboard.kde.org/r/127351/diff/
> 
> 
> Testing
> -------
> 
> Tested with 
> 
> http://www.opf-labs.org/format-corpus/pdfCabinetOfHorrors/fileAttachment.pdf 
> 
> and the PDF file in
> 
> http://www.sdbtransfer.de/app/download/10536876499/SuperSauber1_EDASXbau.zip?t=1453751464
> 
> 
> Thanks,
> 
> Daniel Lichtenberger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160316/69d67798/attachment-0001.html>