[Okular-devel] Review Request 127328: Fix build on Windows (MinGW)

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127328/#review93503
-----------------------------------------------------------




CMakeLists.txt (line 305)
<https://git.reviewboard.kde.org/r/127328/#comment63752>

    Make it `add_library(okularpart MODULE ${okularpart_SRCS})` and you won't need to drop the prefix.



interfaces/viewerinterface.h (line 14)
<https://git.reviewboard.kde.org/r/127328/#comment63751>

    Should use generate_export_header() and generate the export macros at configure time.


- Aleix Pol Gonzalez


On March 14, 2016, 1:17 a.m., Thomas Friedrichsmeier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127328/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 1:17 a.m.)
> 
> 
> Review request for Okular, Aleix Pol Gonzalez, Alex Richardson, and Gleb Popov.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Three parts to this patch:
> 1) The plaform #ifdef in interfaces/viewerinterface.h is platform, not compiler-specific.
> 2) When compiling okularplugin, the existing definition of okularpart_EXPORTS on the generated settings.cpp does not work with MinGW, for reasons that I do not understand. Setting the definition on the whole target, instead, works.
> 3) The okularpart lib will automatically be named libokularpart, and subsequently not be found when trying to load it via KPluginLoader. Tell cmake to drop the "lib"-prefix.
> 
> See also:
> - Discussion on list https://mail.kde.org/pipermail/okular-devel/2016-March/022480.html
> - A previous review request addressed issue 2 for MSVC https://git.reviewboard.kde.org/r/125742/
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e17bc25 
>   interfaces/viewerinterface.h e9e76a2 
>   mobile/components/CMakeLists.txt e09326a 
> 
> Diff: https://git.reviewboard.kde.org/r/127328/diff/
> 
> 
> Testing
> -------
> 
> Builds on Windows with MinGW. Starts, and loads okularpart, successfully.
> 
> 
> Thanks,
> 
> Thomas Friedrichsmeier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160314/8ac2ff8c/attachment.html>