[Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

> On Feb. 19, 2016, 12:27 a.m., Albert Astals Cid wrote:
> > conf/dlggeneralbase.ui, line 391
> > <https://git.reviewboard.kde.org/r/125397/diff/1/?file=408386#file408386line391>
> >
> >     Why did you change the acceletaror?

Oops, by mistake.


> On Feb. 19, 2016, 12:27 a.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 828
> > <https://git.reviewboard.kde.org/r/125397/diff/1/?file=408390#file408390line828>
> >
> >     Isn't that basically if (true) ?

I want to notify slotRelayoutPages when RTL mode is enabled and disabled. However, I fix it with different approach.


- Fahad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review92546
-----------------------------------------------------------


On June 27, 2016, 12:54 p.m., Fahad Al-Saidi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> -----------------------------------------------------------
> 
> (Updated June 27, 2016, 12:54 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 325650
>     http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's settings.
> 
> 
> Diffs
> -----
> 
>   conf/dlggeneral.cpp 9945522 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg d90fe23 
>   ui/pageview.cpp 26373bb 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> -------
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160627/5f49bbec/attachment.html>