[Okular-devel] Review Request 126406: Okular should warn if closing with multiple tabs opened

[torham zed]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126406/
-----------------------------------------------------------

(Updated June 1, 2016, 12:08 a.m.)


Review request for Okular and Albert Astals Cid.


Changes
-------

Regarding our conversation in IRC last night, I resolved the issue with the close button.  Setting questionYesNo to static is why the close button stops working.

I made a few other changes, this is now ready to go and should pass scrutiny.

Tested using one tab or multiple tabs, 'do not show again', etc.


Bugs: 334019
    http://bugs.kde.org/show_bug.cgi?id=334019


Repository: okular


Description
-------

Multi tab popup warning


Diffs (updated)
-----

  home/user/projects/OkularOriginal/shell/shell.cpp d80def4 

Diff: https://git.reviewboard.kde.org/r/126406/diff/


Testing
-------

Opened several pdf files, closed entire program with multiple files open to see if popup properly functions along with the 'yes' and 'no' buttons.


Thanks,

torham zed

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160601/9093e533/attachment.html>