[Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

Fahad Al-Saidi fahad.alsaidi at gmail.com
Mon Jul 25 23:39:59 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/
-----------------------------------------------------------

(Updated July 26, 2016, 1:39 a.m.)


Status
------

This change has been marked as submitted.


Review request for Okular and Albert Astals Cid.


Changes
-------

Submitted with commit 04908dba2f93842a0008ef1ba8c966621c615f9e by Olivier CHURLAUD to branch master.


Bugs: 325650
    http://bugs.kde.org/show_bug.cgi?id=325650


Repository: okular


Description
-------

This is my first patch to okular, so I am newbie here. This patch adds RTL reading mode to okular in following view modes:
- facing pages.
- facing ( center first page).
- Overview.

As well as adds “Right to left reading direction “ option to okular's settings.


Diffs
-----

  conf/dlggeneral.cpp 9945522 
  conf/dlggeneralbase.ui 03d5d5d 
  conf/okular.kcfg d90fe23 
  ui/pageview.cpp 26373bb 

Diff: https://git.reviewboard.kde.org/r/125397/diff/


Testing
-------

I have tested in pdf & ODF files and it works fine.


Thanks,

Fahad Al-Saidi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160725/d0dc6193/attachment-0001.html>


More information about the Okular-devel mailing list