[Okular-devel] Review Request 128507: Port: Open relative path again

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128507/#review97771
-----------------------------------------------------------




core/document.cpp (line 4003)
<https://git.reviewboard.kde.org/r/128507/#comment65855>

    `browse->url().scheme() == QLatin1String("mailto")` ?



core/document.cpp (line 4018)
<https://git.reviewboard.kde.org/r/128507/#comment65856>

    QUrl -> QString can be quite expensive, best cache the result in a local variable



core/document.cpp (line 4029)
<https://git.reviewboard.kde.org/r/128507/#comment65858>

    This won't work with remote URLs, I think `KIO::upUrl(d->m_url).resolved(url)` should do the same as the kdelibs4 code


- Alex Richardson


On July 22, 2016, 6:21 p.m., Olivier Churlaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128507/
> -----------------------------------------------------------
> 
> (Updated July 22, 2016, 6:21 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> This brings back the opening of files with relative path.
> 
> However it was written "correct this mess", and I just did a port of what was there. Do I push it anyway?
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d999cbe 
>   core/document.cpp 2f99a8c 
> 
> Diff: https://git.reviewboard.kde.org/r/128507/diff/
> 
> 
> Testing
> -------
> 
> Compiled and Tested
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160723/5dd722e4/attachment-0001.html>