[Okular-devel] Review Request 125442: [okular] fix Arabic & Hebrew search

[Olivier Churlaud]

> On July 21, 2016, 11:18 a.m., Olivier Churlaud wrote:
> > Is the "future work" a lot to do? Because if is part of solving your problem, you should had this to the review.
> 
> Fahad Al-Saidi wrote:
>     Well, the bug itself needs to be retested against Poppler >= 0.40 because of this:
>     https://bugs.freedesktop.org/show_bug.cgi?id=55977
>     
>     Unfortunatly, I am using kde 4 & ubuntu 14.04 and it is diffcult for me to upgrade right now.
> 
> Olivier Churlaud wrote:
>     I have a newer poppler, so if you add to the bug (on bugzilla) a file test, with a word to test (because I don't have an hebrew or arabic keyboard), I can test it.
> 
> Fahad Al-Saidi wrote:
>     done. please test
> 
> Fahad Al-Saidi wrote:
>     well, the current patch will fix the problem though is not the best solution IMHO. We need refactoring text layer in okular that okular get text from poppler without any modification the same way envice does.I mean by future work is another bug relating to RTL in general.
>     If it fine with you to go ahead with this patch, I will clean it up.

I'll speak with Albert about that. Honestly this would be a workaround and this means okular does extra work. I'm not familiar with this part of the codebase. I'll keep you updated


- Olivier


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125442/#review97695
-----------------------------------------------------------


On Sept. 29, 2015, 7:42 a.m., Fahad Al-Saidi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125442/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 7:42 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 207748
>     http://bugs.kde.org/show_bug.cgi?id=207748
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Since arabic search does not work properly in all but pdf  backends, this is a quick attempt to fix this problem. I assumed that text in okular document is in the logical order[ it is a bug by itself]. So by mirroring the search text, the search function works again. 
> 
> The limitation:
> - you can not search arabic and english text together.
> 
> Future work:
> we need to check that text generated by poppler is placed in Visual order, so when we copy it and paste it in text editor is still readable.
> 
> 
> Diffs
> -----
> 
>   ui/searchlineedit.cpp c736759 
> 
> Diff: https://git.reviewboard.kde.org/r/125442/diff/
> 
> 
> Testing
> -------
> 
> Tested in Arabic & Hebrew pdfs and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160721/b0547750/attachment.html>