[Okular-devel] Review Request 125442: [okular] fix Arabic & Hebrew search

[Olivier Churlaud]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125442/#review97695
-----------------------------------------------------------



Is the "future work" a lot to do? Because if is part of solving your problem, you should had this to the review.

- Olivier Churlaud


On Sept. 29, 2015, 7:42 a.m., Fahad Al-Saidi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125442/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 7:42 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 207748
>     http://bugs.kde.org/show_bug.cgi?id=207748
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Since arabic search does not work properly in all but pdf  backends, this is a quick attempt to fix this problem. I assumed that text in okular document is in the logical order[ it is a bug by itself]. So by mirroring the search text, the search function works again. 
> 
> The limitation:
> - you can not search arabic and english text together.
> 
> Future work:
> we need to check that text generated by poppler is placed in Visual order, so when we copy it and paste it in text editor is still readable.
> 
> 
> Diffs
> -----
> 
>   ui/searchlineedit.cpp c736759 
> 
> Diff: https://git.reviewboard.kde.org/r/125442/diff/
> 
> 
> Testing
> -------
> 
> Tested in Arabic & Hebrew pdfs and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160721/09c4f23e/attachment.html>