[Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Olivier Churlaud]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review97673
-----------------------------------------------------------



Mostly style correction. Then I think it will be fine. (I'll check again)


ui/pageview.cpp (line 829)
<https://git.reviewboard.kde.org/r/125397/#comment65822>

    Trailing space here to remove



ui/pageview.cpp (line 4400)
<https://git.reviewboard.kde.org/r/125397/#comment65823>

    Please be sure to respect the indentation



ui/pageview.cpp (line 4416)
<https://git.reviewboard.kde.org/r/125397/#comment65824>

    Still indentation and 
    
    ]else { => } else {


- Olivier Churlaud


On June 27, 2016, 2:54 p.m., Fahad Al-Saidi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> -----------------------------------------------------------
> 
> (Updated June 27, 2016, 2:54 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 325650
>     http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's settings.
> 
> 
> Diffs
> -----
> 
>   conf/dlggeneral.cpp 9945522 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg d90fe23 
>   ui/pageview.cpp 26373bb 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> -------
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160720/5f40397f/attachment.html>