[Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

[Martin Tobias Holmedahl Sandsmark]

> On July 13, 2016, 10:04 p.m., Aleix Pol Gonzalez wrote:
> > shell/shell.cpp, line 435
> > <https://git.reviewboard.kde.org/r/128435/diff/1/?file=471627#file471627line435>
> >
> >     Why? Shouldn't this depend on the standard in the platform? Why would we need to hide this?

because showing all the file endings leads to an unusably large dropdown.


> On July 13, 2016, 10:04 p.m., Aleix Pol Gonzalez wrote:
> > shell/shell.cpp, line 440
> > <https://git.reviewboard.kde.org/r/128435/diff/1/?file=471627#file471627line440>
> >
> >     Use foreach or qAsConst.

isn't m_fileformats already detached?


> On July 13, 2016, 10:04 p.m., Aleix Pol Gonzalez wrote:
> > shell/shell.cpp, line 441
> > <https://git.reviewboard.kde.org/r/128435/diff/1/?file=471627#file471627line441>
> >
> >     I think it would make sense to move that logic upstream.
> >     
> >     It's not something specific about okular.

move which logic to which upstream? QFileDialog?


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128435/#review97361
-----------------------------------------------------------


On July 13, 2016, 9:57 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128435/
> -----------------------------------------------------------
> 
> (Updated July 13, 2016, 9:57 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Aleix Pol Gonzalez.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Without the Plasma QPA now the file open dialog just lets you select a single random filetype to view at the time. This tries to improve that, but I'm not sure if that's something you/we want?
> 
> 
> Diffs
> -----
> 
>   shell/shell.cpp bca7206 
> 
> Diff: https://git.reviewboard.kde.org/r/128435/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160717/d4c9c81e/attachment-0001.html>