[Okular-devel] Review Request 128450: Ask confirmation to exit okular when several tabs are open

[Olivier Churlaud]

> On July 14, 2016, 3:08 p.m., Luigi Toscano wrote:
> > See also:
> > https://git.reviewboard.kde.org/r/126406/
> > and https://bugs.kde.org/show_bug.cgi?id=334019

Didn't know this. My patch is simplier, but don't check for modified tabs (it is done by default it seems) and doesn't have the don't bother me again. Why didn't the other get a ship it?


- Olivier


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128450/#review97400
-----------------------------------------------------------


On July 14, 2016, 3:02 p.m., Olivier Churlaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128450/
> -----------------------------------------------------------
> 
> (Updated July 14, 2016, 3:02 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> I keep closing my whole okular session instead of only one tab. This fixes it in the same way firefox does.
> 
> I didn't add a "[] don't bother me again" :  should I?
> 
> 
> Diffs
> -----
> 
>   shell/shell.h d015b3f 
>   shell/shell.cpp bca7206 
> 
> Diff: https://git.reviewboard.kde.org/r/128450/diff/
> 
> 
> Testing
> -------
> 
> Compiles on master and frameworks.
> 
> Has expected behavior on frameworks, I cannot set my environnment for the kde4 version.
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160714/23f89a71/attachment.html>