[Okular-devel] Review Request 128441: Fonts are scanned again by poppler5

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128441/#review97360
-----------------------------------------------------------


Ship it!




Ship It!

- Albert Astals Cid


On July 13, 2016, 6:40 p.m., Olivier Churlaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128441/
> -----------------------------------------------------------
> 
> (Updated July 13, 2016, 6:40 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> The fonts were not scanned anymore in poppler because the function was commented.
> 
> 2 things to review:
> 1) I removed in the equality comparaison of FontInfo the native identifier. I add to do this because it was always false. If it's wrong to do this, how should I do?
> 2) It's very unefficient to recreate a page iterator for each page instead of iterating over the pages directly. (see the code)
> 
> 
> Diffs
> -----
> 
>   core/document.cpp af842e1 
>   core/fontinfo.cpp 59ea79f 
>   generators/poppler/generator_pdf.cpp 3b53f41 
> 
> Diff: https://git.reviewboard.kde.org/r/128441/diff/
> 
> 
> Testing
> -------
> 
> No influence on tests
> Compile, show the fonts
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160713/f86e2ab0/attachment.html>