[Okular-devel] Review Request 128436: Restore --unique behavior

[Olivier Churlaud]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128436/
-----------------------------------------------------------

(Updated July 13, 2016, 9:06 p.m.)


Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl Sandsmark.


Repository: okular


Description
-------

As I didn't know what unique was exactly for, here is what I considered (if I'm wrong, please correct me):

User wants only one instance of okular so he starts it with --unique flag. From now on, every time he starts okular without the flag, it will raise the current instance. Opening a new file /should/ open a tab (currently overwrites the last one).

In my opinion, if another --unique is started, it should drop the --unique (it is not the case now: it starts a new instance).

Still to do as I see it: 
 - open new documents in new tabs by default (in unique mode)
 - allow opening several documents at once in unique mode
 - Drop --unique if another session already exist


Diffs
-----

  shell/okular_main.cpp 2285f64 

Diff: https://git.reviewboard.kde.org/r/128436/diff/


Testing
-------

Compile, behave as described above.


Thanks,

Olivier Churlaud

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160713/80c8822e/attachment.html>