[Okular-devel] Review Request 128424: Register Okular to DBus to get back "open in new tab" feature

Olivier Churlaud olivier at churlaud.com
Tue Jul 12 19:15:04 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128424/
-----------------------------------------------------------

(Updated July 12, 2016, 7:15 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl Sandsmark.


Changes
-------

Submitted with commit e3e2b7c6e30073acd54766cba8a744058dfd06c1 by Olivier CHURLAUD to branch frameworks.


Repository: okular


Description
-------

Register okular in dbus.

In the same time I corrected an error message "QCommandLineParser:: ... no 'raise' option". I can commit it separately or not at all.


Diffs
-----

  shell/main.cpp 856d2b0 
  shell/shell.cpp 62a6a33 
  shell/shellutils.cpp 296a758 

Diff: https://git.reviewboard.kde.org/r/128424/diff/


Testing
-------

Compiled and feature back. However, maybe other options are needed in to be exposed? I don't know the codebase enough to say.


Thanks,

Olivier Churlaud

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160712/6d1213eb/attachment-0001.html>


More information about the Okular-devel mailing list