[Okular-devel] Review Request 128424: Register Okular to DBus to get back "open in new tab" feature

[Martin Tobias Holmedahl Sandsmark]

> On July 11, 2016, 10:51 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > Looks good to me, does basically the same as KDBusService.
> 
> Olivier Churlaud wrote:
>     Should I wait for a Ship it? A review from Albert?
>     
>     What about the noraise/raise bit ?

the noraise/raise bit is so trivial I don't think it even needs a separate commit.

I'll give you a shipit, I can't see how this code could possibly be wrong, and then Albert can rather tell me off if it was wrong. :-)


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128424/#review97297
-----------------------------------------------------------


On July 11, 2016, 10:05 p.m., Olivier Churlaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128424/
> -----------------------------------------------------------
> 
> (Updated July 11, 2016, 10:05 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Register okular in dbus.
> 
> In the same time I corrected an error message "QCommandLineParser:: ... no 'raise' option". I can commit it separately or not at all.
> 
> 
> Diffs
> -----
> 
>   shell/main.cpp 856d2b0 
>   shell/shell.cpp 62a6a33 
>   shell/shellutils.cpp 296a758 
> 
> Diff: https://git.reviewboard.kde.org/r/128424/diff/
> 
> 
> Testing
> -------
> 
> Compiled and feature back. However, maybe other options are needed in to be exposed? I don't know the codebase enough to say.
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160712/84d9e22b/attachment.html>