[Okular-devel] Review Request 128424: Register Okular to DBus to get back "open in new tab" feature

[Olivier Churlaud]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128424/
-----------------------------------------------------------

(Updated July 11, 2016, 11:22 p.m.)


Review request for Okular and Albert Astals Cid.


Changes
-------

Realized that the dbus was happening somewhere else: moved to shell.cpp


Repository: okular


Description
-------

Register okular in dbus.

In the same time I corrected an error message "QCommandLineParser:: ... no 'raise' option". I can commit it separately or not at all.


Diffs (updated)
-----

  shell/main.cpp 856d2b0 
  shell/shell.cpp 62a6a33 
  shell/shellutils.cpp 296a758 

Diff: https://git.reviewboard.kde.org/r/128424/diff/


Testing
-------

Compiled and feature back. However, maybe other options are needed in to be exposed? I don't know the codebase enough to say.


Thanks,

Olivier Churlaud

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160711/74e42d6f/attachment-0001.html>