[Okular-devel] Review Request 126913: use QScreen unconditionally instead of libkscreen

[Albert Astals Cid]

> On Jan. 28, 2016, 12:38 p.m., David Edmundson wrote:
> > core/utils.cpp, lines 144-158
> > <https://git.reviewboard.kde.org/r/126913/diff/1/?file=441858#file441858line144>
> >
> >     you missed out all of this bit which does validity checks

Yeah, also that function you use is known for returning bogus values on places like xvfb so please bring back the validity checks.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126913/#review91705
-----------------------------------------------------------


On Jan. 28, 2016, 3:07 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126913/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 3:07 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> This patch removes libkscreen usage and ports it to QScreen.
>     
>     - Instead of retrieving and polishing the DPI from libkscreen, use
>       the widget's windowhandle to retrieve the current screen and return
>       that as the widget's DPI.
>     
>     - Remove libkscreen from buildsystem
>     
>     - Kill old libkscreen code. This wasn't built anyway, and wouldn't build
>       against new libkscreen anyway.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 492de00 
>   config-okular.h.cmake 4b4b2ee 
>   core/utils.cpp 2aa8f07 
> 
> Diff: https://git.reviewboard.kde.org/r/126913/diff/
> 
> 
> Testing
> -------
> 
> little, started okular on my laptop and viewed a pdf, nothing odd going on...
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160130/836c6fc1/attachment.html>