[Okular-devel] Review Request 126842: Port to FindPoppler from extra-cmake-modules.

[Albert Astals Cid]

> On Jan. 22, 2016, 2:45 p.m., Alex Richardson wrote:
> > This is missing the checks for various poppler versions that the old module did. I have a similar patch locally but not yet pushed the change to use the e-c-m module as that is not in a released version yet.
> > 
> > Not sure what the current policy on the frameworks branch of Okular is? is okular frameworks depends on KF5 git master okay? Also what about the minimum Qt version?

No, depending on non released e-c-m is just going to make it harder for everyone to develop, so do not do it.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126842/#review91441
-----------------------------------------------------------


On Jan. 22, 2016, 12:31 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126842/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 12:31 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Some small changes are required to ensure build passes with ECM's new FindPoppler.cmake.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 492de006c58904f0da94f4cfb9e2ca79ab839c45 
>   cmake/modules/FindPoppler.cmake 80a78627438703a9db4d7cd97649098c41b1b2ce 
>   generators/CMakeLists.txt ce1d9bfeeb401466c47648d1d828fbd2ff4b18f6 
>   generators/poppler/CMakeLists.txt 740b6fd8d6311bee80845a034bba148d443afbd4 
> 
> Diff: https://git.reviewboard.kde.org/r/126842/diff/
> 
> 
> Testing
> -------
> 
> Builds, PDFs still open.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160130/c0cd25ff/attachment.html>