[Okular-devel] Review Request 126406: Okular should warn if closing with multiple tabs opened

[torham zed]

> On Jan. 4, 2016, 11:25 p.m., Albert Astals Cid wrote:
> > home/user/projects/OkularOriginal/shell/shell.cpp, line 487
> > <https://git.reviewboard.kde.org/r/126406/diff/1/?file=424331#file424331line487>
> >
> >     Use one of the QMessageBox statics instead of constructing the messagebox directly, even better use KMessageBox for this kdelibs4-based code.

I changed the code to use KMessageBox.  Does not yet implement code linked to checkbox(checkbox is present), wanted to confirm and resolve current outstanding items.


- torham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126406/#review90614
-----------------------------------------------------------


On Jan. 4, 2016, 11:26 p.m., torham zed wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126406/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 11:26 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 334019
>     http://bugs.kde.org/show_bug.cgi?id=334019
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Multi tab popup warning
> 
> 
> Diffs
> -----
> 
>   home/user/projects/OkularOriginal/shell/shell.cpp d80def4 
> 
> Diff: https://git.reviewboard.kde.org/r/126406/diff/
> 
> 
> Testing
> -------
> 
> Opened several pdf files, closed entire program with multiple files open to see if popup properly functions along with the 'yes' and 'no' buttons.
> 
> 
> Thanks,
> 
> torham zed
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160128/d5a24a79/attachment.html>