[Okular-devel] Review Request 126913: use QScreen unconditionally instead of libkscreen

Sebastian Kügler sebas at kde.org
Thu Jan 28 03:07:08 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126913/
-----------------------------------------------------------

Review request for Okular and Albert Astals Cid.


Repository: okular


Description
-------

This patch removes libkscreen usage and ports it to QScreen.
    
    - Instead of retrieving and polishing the DPI from libkscreen, use
      the widget's windowhandle to retrieve the current screen and return
      that as the widget's DPI.
    
    - Remove libkscreen from buildsystem
    
    - Kill old libkscreen code. This wasn't built anyway, and wouldn't build
      against new libkscreen anyway.


Diffs
-----

  CMakeLists.txt 492de00 
  config-okular.h.cmake 4b4b2ee 
  core/utils.cpp 2aa8f07 

Diff: https://git.reviewboard.kde.org/r/126913/diff/


Testing
-------

little, started okular on my laptop and viewed a pdf, nothing odd going on...


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160128/566010bc/attachment.html>


More information about the Okular-devel mailing list