[Okular-devel] Review Request 126613: Add support for various middle mouse button press behaviour

Dmitry Osipenko digetx at gmail.com
Tue Jan 12 23:08:53 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126613/
-----------------------------------------------------------

(Updated Янв. 12, 2016, 11:08 п.п.)


Review request for Okular.


Bugs: 219121
    http://bugs.kde.org/show_bug.cgi?id=219121


Repository: okular


Description
-------

Make middle mouse button press behaviour configurable, so it could be:

 - Zoom page
 - Drag page
 - Page auto scrolling
 - Disabled

Add "Control Methods" config option to the accessibility menu in order to
change the behaviour.


Diffs
-----

  CMakeLists.txt 97e8db6e4a704fd34331fad7b7628ca2248b62d8 
  conf/dlgaccessibilitybase.ui 9e76a754a4a5b9fe5e0a9278a92c8cc7ee175a5f 
  conf/okular.kcfg e75861e43776718fc4e1ce9156d35faf4be00b55 
  ui/autoscrollpopup.h PRE-CREATION 
  ui/autoscrollpopup.cpp PRE-CREATION 
  ui/data/CMakeLists.txt 491b9935760d0fa81d46b6007f7f44e5e679156b 
  ui/data/autoscroll.png PRE-CREATION 
  ui/pageview.h 7fa1f13fc886c702ad57ba55dc231dca582d5ec7 
  ui/pageview.cpp 3ebf7dcb04aa1942e02f49133d98081e2bbb565c 

Diff: https://git.reviewboard.kde.org/r/126613/diff/


Testing (updated)
-------

All default mouse modes (drag, zoom, text selection, annotations open/close/move...) + all new middle button modes.

Correctness of simultanious mouse button presses (like left button text selection while scrolling/dragging with a mid button), enter/exit mid button scrolling/dragging by other mouse button click or keyboard press.

Scrolling: no drawing issues, no last page overrun.


Thanks,

Dmitry Osipenko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160112/439ebff7/attachment-0001.html>


More information about the Okular-devel mailing list