[Okular-devel] Review Request 126193: Port to new JSON plugin loading system

Alex Richardson arichardson.kde at gmail.com
Mon Jan 4 15:08:27 UTC 2016 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126193/
-----------------------------------------------------------

(Updated Jan. 4, 2016, 3:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Changes
-------

Submitted with commit 2f9246ae42ce6276002641ac02d9c6b880bcf7a3 by Alex Richardson to branch frameworks.


Repository: okular


Description
-------

Two commits:

---

Port to new JSON plugin loading system

This means Okular can now work without ksycoca and KDELibs4Support.

---

Bring back the about backend dialog


Diffs
-----

  CMakeLists.txt 4aea44db6940d4a34c24d30d54c3980d2170e89f 
  core/document.h 1e49b3362574f70de49daefd4558e04cb0e1a423 
  core/document.cpp 04a29fd1be29f1c464b2d9d08ae20ba9e0b937ef 
  core/document_p.h 73f5797a5552f7590ad50f019893d9bf2844a90c 
  core/generator.h b225dc1a5940fc07d35f0f545aedec10a5beb03a 
  generators/CMakeLists.txt 0e0d44a7ce2551a3794e130a84c2a13ab3046116 
  generators/chm/CMakeLists.txt 471258bd036ef453d021e350392c4adbf3c7d47e 
  generators/chm/generator_chm.cpp 5163d5f104da8bf517befeb702ba9aefee6b0236 
  generators/chm/libokularGenerator_chmlib.desktop dc3ac9308fc2447f3b11f96c5618058ca95832fc 
  generators/chm/libokularGenerator_chmlib.json PRE-CREATION 
  generators/chm/okularChm.desktop ed42bc25c87ee1fafe1a729d3f14f1c75e5784dd 
  generators/comicbook/CMakeLists.txt deed292fd179535dfed129cdb6007b49668bafa9 
  generators/comicbook/generator_comicbook.cpp dd5b0ffffe216150e521e234c9a00c9414cc0a87 
  generators/comicbook/libokularGenerator_comicbook.desktop 5a91a5fdd053819d75d28f93de152b9c904f41ff 
  generators/comicbook/libokularGenerator_comicbook.json PRE-CREATION 
  generators/comicbook/okularComicbook.desktop 1dded78f4245d2770f1431f7e02123c2fa681ac9 
  generators/djvu/CMakeLists.txt 34dc1a139eaae868464fb158a35408000ffc2ed7 
  generators/djvu/generator_djvu.cpp 740e38c665b7f3a0d174b56c2fbe2bbc5fb5cfe0 
  generators/djvu/libokularGenerator_djvu.desktop 887377998ce55802cd505c42e359919cb814d615 
  generators/djvu/libokularGenerator_djvu.json PRE-CREATION 
  generators/djvu/okularDjvu.desktop 1c2fd43b63f071f9d726e1a605681d32bc93d25f 
  generators/dvi/CMakeLists.txt 38f321a1118f68027a2e1e365f79ee607f67bfe7 
  generators/dvi/generator_dvi.cpp 2db4bc4303807f04776a8d0d7c20c46aff695bb2 
  generators/dvi/libokularGenerator_dvi.desktop 39edcfadf8fb0273c7b7f1bde2912566db605c61 
  generators/dvi/libokularGenerator_dvi.json PRE-CREATION 
  generators/dvi/okularDvi.desktop 5c7d3a96021a887171a6d98f0693ad88bc967f29 
  generators/epub/CMakeLists.txt 41ecd23a4d04997aef297f190da8f1b06e0732d8 
  generators/epub/generator_epub.cpp d8d8b07d24e897c3b27cdf13a99120f434f73e82 
  generators/epub/libokularGenerator_epub.desktop 14d64159fd2e51ce91de3abde3cb0380c9ffe0c8 
  generators/epub/libokularGenerator_epub.json PRE-CREATION 
  generators/epub/okularEPub.desktop 2da8c9097f1764aaee675a183b4d4eb4586d44b1 
  generators/fax/CMakeLists.txt 22b595e2ff9ce3bac6cf82b4142da02e3732fbb6 
  generators/fax/generator_fax.cpp 823db2723f3373c058139a521861f7cd7a623cfb 
  generators/fax/libokularGenerator_fax.desktop fcffa707b157a91f84a43a8c6e8ac5b93363fef9 
  generators/fax/libokularGenerator_fax.json PRE-CREATION 
  generators/fax/okularFax.desktop 8b86b91ed02b6e15547686e2f9a589f80516ce84 
  generators/fictionbook/CMakeLists.txt 1ab52891e0772df8e301646c1a259fd49b229f89 
  generators/fictionbook/generator_fb.cpp c5d5dddeb70ea66ff6276855e4163453d9823a16 
  generators/fictionbook/libokularGenerator_fb.desktop ee51e8f0003dc1182684353eb79f8f2de69206b8 
  generators/fictionbook/libokularGenerator_fb.json PRE-CREATION 
  generators/fictionbook/okularFb.desktop 998b22486837578c409c7ed7a3534480348415c4 
  generators/kimgio/CMakeLists.txt 5d9011b02ae76daac6b98e390b13857837dd9bc4 
  generators/kimgio/generator_kimgio.cpp 84c155b5ad8da5057a28faaffa417ecb60a64ab3 
  generators/kimgio/libokularGenerator_kimgio.desktop ea483428613943fb3bc0e0535280d4e98c196b68 
  generators/kimgio/libokularGenerator_kimgio.json PRE-CREATION 
  generators/kimgio/okularKimgio.desktop 983c300cb2ad019c9c98b74d896ae28fb01def2a 
  generators/mobipocket/CMakeLists.txt e826c132a03d46532ffdc866c688906915cf6d55 
  generators/mobipocket/generator_mobi.cpp a11d2c508c840e7b94430638fe1138c216b41fed 
  generators/mobipocket/libokularGenerator_mobi.desktop 13a13600e976a2d617d7fb83f03ddeee4d91b738 
  generators/mobipocket/libokularGenerator_mobi.json PRE-CREATION 
  generators/mobipocket/okularMobi.desktop 5a50a33d4c709a26703c9b24be033bdb3ab0419f 
  generators/ooo/CMakeLists.txt eb6f63ca00c898c437c40c68466795b2b8f70f64 
  generators/ooo/generator_ooo.cpp 23708c8d9e7f8653c13d96c76d9046f93154ac48 
  generators/ooo/libokularGenerator_ooo.desktop d769da3d8c94c7035c31cf1469792c82064baede 
  generators/ooo/libokularGenerator_ooo.json PRE-CREATION 
  generators/ooo/okularOoo.desktop f319c8c7aad44ede0228c12461c009184ff77bfc 
  generators/plucker/CMakeLists.txt 9f1f61abaebc2f864bc4e1d5e1c41fb713a6cb1c 
  generators/plucker/generator_plucker.cpp 6850036f79664ac1554e6055ebc36253ac21b0b0 
  generators/plucker/libokularGenerator_plucker.desktop 24756b323ffea2d8c2d0a478f545a00af5be8eda 
  generators/plucker/libokularGenerator_plucker.json PRE-CREATION 
  generators/plucker/okularPlucker.desktop 17c5704d2c34eddf7be27d3e81a9c115fa5377df 
  generators/poppler/CMakeLists.txt a696ffbb8218abb8094afbc0db1b249bc2d9c3c8 
  generators/poppler/generator_pdf.cpp 90db80a41ecef76733ab79ebc41c162725cf30ed 
  generators/poppler/libokularGenerator_poppler.desktop 7b7c778380742f55bcc584d9576ff93d2acb5a9f 
  generators/poppler/libokularGenerator_poppler.json PRE-CREATION 
  generators/poppler/okularPoppler.desktop a1ef1d8aa270e3b543fdb35e776b48abc7e05de8 
  generators/spectre/CMakeLists.txt d7eb0e28d4d15072e0c118dd79b005d8ac9ea9c1 
  generators/spectre/generator_ghostview.cpp e2275af8911ccdf49da3df51692a83f5ba4628ed 
  generators/spectre/libokularGenerator_ghostview.desktop 552459d07928a0397b2b5d7f21ea510241ae3ff0 
  generators/spectre/libokularGenerator_ghostview.json PRE-CREATION 
  generators/spectre/okularGhostview.desktop d5bd725d3e0fbad2517f13e83499764000adf1e9 
  generators/tiff/CMakeLists.txt 89603085fef5fdfd135f04e1d4f0026772a663b0 
  generators/tiff/generator_tiff.cpp cf4f2762a506a07288bb6fb1169ddbceb5a5eccb 
  generators/tiff/libokularGenerator_tiff.desktop 8ca968f655a4b42090e1944354b6981788319854 
  generators/tiff/libokularGenerator_tiff.json PRE-CREATION 
  generators/tiff/okularTiff.desktop cfc2b3943fc2c5bb93fac3c26ed75267234135ae 
  generators/txt/CMakeLists.txt b095f29e9dc2aa49ec851fdd678d55bd723f1948 
  generators/txt/generator_txt.cpp cffe8473012768c86c55263a1a65eb2ae358b7ec 
  generators/txt/libokularGenerator_txt.desktop df6b0623aee49a644a490827cd755bac1e3a39ca 
  generators/txt/libokularGenerator_txt.json PRE-CREATION 
  generators/txt/okularTxt.desktop e9dda9f695c474c9176a8b32b3bffcc1519222ac 
  generators/xps/CMakeLists.txt 1430bda1dd03229930fbc866ee87d277e0c2bba9 
  generators/xps/generator_xps.cpp 58bf0f638a70b07514570b4e4502bdc82f6378c7 
  generators/xps/libokularGenerator_xps.desktop 173ba72ffe47a4834c5e125b32b969a4c6fac2d3 
  generators/xps/libokularGenerator_xps.json PRE-CREATION 
  generators/xps/okularXps.desktop 2e5a2c47cb50180edd22d2ec8b910d8708b854c2 
  part.cpp ab11a25605c623c20a7c3da5a642df993f9c1859 
  ui/fileprinterpreview.cpp 70fd941b03c30b1a9f34ad12a2ee018d37172fff 

Diff: https://git.reviewboard.kde.org/r/126193/diff/


Testing
-------

unit tests still pass, opening files works


Thanks,

Alex Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160104/5ab13449/attachment.html>

More information about the Okular-devel mailing list