[Okular-devel] Review Request 126445: i18n issue missing setApplicationDomain

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126445/#review90489
-----------------------------------------------------------

Ship it!


The description is a bit weird, please make it be a full sentence not "so cjacker..."


shell/main.cpp (line 33)
<https://git.reviewboard.kde.org/r/126445/#comment61879>

    Make sure that when commiting the spacing is good (there's an extra space as marked in red)


- Albert Astals Cid


On gen. 3, 2016, 7:47 a.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126445/
> -----------------------------------------------------------
> 
> (Updated gen. 3, 2016, 7:47 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> so cjacker just added
> 
> ```
> KLocalizedString::setApplicationDomain("okular");
> ```
> 
> 
> Diffs
> -----
> 
>   shell/main.cpp 77847ba 
> 
> Diff: https://git.reviewboard.kde.org/r/126445/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160103/6b5332ec/attachment.html>