[Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review92546
-----------------------------------------------------------



Is this something that one would expect to set manually? Shouldn't it be detected from the file contents? Or that's just too hard/not optimal?


conf/dlggeneralbase.ui (line 388)
<https://git.reviewboard.kde.org/r/125397/#comment63096>

    Why did you change the acceletaror?



ui/pageview.cpp (line 828)
<https://git.reviewboard.kde.org/r/125397/#comment63097>

    Isn't that basically if (true) ?


- Albert Astals Cid


On Sept. 25, 2015, 4:05 p.m., Fahad Al-Saidi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 4:05 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 325650
>     http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's settings.
> 
> 
> Diffs
> -----
> 
>   conf/dlggeneral.cpp ad389f3 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg 76d7c37 
>   conf/preferencesdialog.h dcea37e 
>   interfaces/viewerinterface.h 4f27921 
>   ui/pageview.cpp 6bff6ac 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> -------
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160219/be6b96bf/attachment.html>