[Okular-devel] Review Request 127049: Port to FindPoppler from extra-cmake-modules

[Armin K.]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127049/#review92445
-----------------------------------------------------------



e-c-m 5.19 has been released. Can I get a green light on this one?

- Armin K.


On Feb. 14, 2016, 3:43 p.m., Armin K. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127049/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2016, 3:43 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> This changes cmake machinery to support FindPoppler which was recently added to extra-cmake-modules.
> 
> FindPoppler was added in extra-cmake-modules-5.19, so the dep needed to be raised.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b93c5f9 
>   cmake/modules/FindPoppler-Qt5.cmake 80a7862 
>   generators/CMakeLists.txt e2bd28e 
>   generators/poppler/CMakeLists.txt 248825e 
> 
> Diff: https://git.reviewboard.kde.org/r/127049/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160216/56ab26bf/attachment.html>