[Okular-devel] Review Request 127021: Remove most KDELibs4Support linking
Albert Astals Cid
aacid at kde.org
Tue Feb 16 00:37:36 UTC 2016
> On Feb. 9, 2016, 11:23 p.m., Albert Astals Cid wrote:
> > The new dialog "file type" looks fugly and tehre's no "all file types" anymore.
>
> Aleix Pol Gonzalez wrote:
> https://git.reviewboard.kde.org/r/127024/
>
> :)
>
> Albert Astals Cid wrote:
> that won't fix http://i.imgur.com/AwIzhqr.png right? That's the Qt dialog i guess? Is it really supposed to be that ugly?
>
> Aleix Pol Gonzalez wrote:
> You don't have it set up properly, you should be getting the normal KFileWidget-based dialog.
I know i don't have it setup to give me the "Plasma experience", it's giving me the "Okular experience outside plasma", and it is a serious regression to what we have by using KFileDialog, don't you think?
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/#review92202
-----------------------------------------------------------
On Feb. 10, 2016, 2:23 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127021/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 2:23 a.m.)
>
>
> Review request for Okular.
>
>
> Repository: okular
>
>
> Description
> -------
>
> Drops KDELibs4Support usage, mostly it wasn't actually used, except for that KFileDialog usage that I ported.
>
>
> Diffs
> -----
>
> shell/shell.cpp c97054a
>
> Diff: https://git.reviewboard.kde.org/r/127021/diff/
>
>
> Testing
> -------
>
> Opening dialog seems to work fine, tests still pass except for parttest, but I'm unsure it's related: https://paste.kde.org/p37pdubgf
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160216/956268d7/attachment.html>
More information about the Okular-devel
mailing list