[Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/#review92196
-----------------------------------------------------------




shell/shell.cpp (lines 401 - 402)
<https://git.reviewboard.kde.org/r/127021/#comment62890>

    Braces (I guess?)
    
    Also, range-for


- Kai Uwe Broulik


On Feb. 9, 2016, 2:51 nachm., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127021/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 2:51 nachm.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Drops KDELibs4Support usage, mostly it wasn't actually used, except for that KFileDialog usage that I ported.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 4530c33 
>   generators/mobipocket/CMakeLists.txt 87995e3 
>   shell/CMakeLists.txt 7a6af74 
>   shell/shell.cpp c97054a 
> 
> Diff: https://git.reviewboard.kde.org/r/127021/diff/
> 
> 
> Testing
> -------
> 
> Opening dialog seems to work fine, tests still pass except for parttest, but I'm unsure it's related: https://paste.kde.org/p37pdubgf
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160209/f908ca1d/attachment.html>