[Okular-devel] [okular] [Bug 342076] The marker for the current section only shows up for the first page of a chapter

miklos via KDE Bugzilla bugzilla_noreply at kde.org
Sat Feb 6 18:44:07 UTC 2016


https://bugs.kde.org/show_bug.cgi?id=342076

--- Comment #7 from miklos <mtmkls at freemail.hu> ---
Created attachment 97055
  --> https://bugs.kde.org/attachment.cgi?id=97055&action=edit
okular_marker.diff

(In reply to Albert Astals Cid from comment #6)
> I disagree, and actually querying the whole TOC tree is quite a bad idea
> since on big documents it can be veeeeeeeeeeeeeeery slow.
> 
> But if someone comes up with a patch we can discuss over it.

Today I noticed that this bug is still open, and I decided to take a look at
the code. You worry about querying the whole TOC tree? The current code does
exactly that to find the items matching the current page!

I came up with the attached patch that half-solves the problem, and doesn't go
over the entire TOC tree :) The remaining task is to teach TOCModel::data() to
only set KIcon to nodes that either have no children or are not expanded. The
latter is a bit difficult, as the model knows nothing about the treeview. I'm
open to suggestions.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Okular-devel mailing list