Review Request 129288: Fix unused computation result warning in plucker

Miklós Máté mtmkls at gmail.com
Wed Dec 14 22:52:16 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129288/
-----------------------------------------------------------

(Updated Dec. 14, 2016, 11:52 p.m.)


Status
------

This change has been discarded.


Review request for Okular.


Repository: okular


Description
-------

If we assume that the code was correct, then the pointer dereference is unnecessary. If we assume that the code was wrong, then it probably wanted to do (*font)--. I assumed the former, but I can't test it.


Diffs
-----

  generators/plucker/unpluck/qunpluck.cpp 8363dd3 

Diff: https://git.reviewboard.kde.org/r/129288/diff/


Testing
-------


Thanks,

Miklós Máté

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20161214/594799a7/attachment.html>


More information about the Okular-devel mailing list