Review Request 129584: fix loading eps

[Albert Astals Cid]

> On Dec. 1, 2016, 11:50 p.m., Albert Astals Cid wrote:
> > First past is correct i guess, somehow qimage* lost the hability to load eps files.
> > 
> > But the second part i'd prefer if you could try porting https://github.com/KDE/okular/commit/3f1ec4cee7066b8208f084621787c7740e68d59d that effectevely should fix this problem in a better way and somehow it got lost in the KF5 port.
> 
> Wolfgang Bauer wrote:
>     kimageformats contains an eps plugin for qimageio though.
>     https://cgit.kde.org/kimageformats.git/tree/src/imageformats
>     
>     Okular from git master displays eps files fine here using the kimgio backend.
>     Though spectre would still be the better choice of course.
> 
> Miklós Máté wrote:
>     On my system (Debian Unstable) kimgio says unsupported file format. I just submitted a new review request that can replace the last hunk.
> 
> Luigi Toscano wrote:
>     Did you install kimageformat-plugins?
> 
> Miklós Máté wrote:
>     I didn't even know that package existed.

I did https://cgit.kde.org/okular.git/commit/?h=Applications/16.12&id=ecf54e42035e7c96a0c0a435ba01d1b3483d032a

I thing we can now discard this review request, now if the kimgio generator was the first choice (that isn't anymore due to your other review request) and it failed it would try the next generator in offer instead of failing directly.

Do you agree?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129584/#review101206
-----------------------------------------------------------


On Nov. 29, 2016, 3:13 p.m., Miklós Máté wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129584/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 3:13 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> There were two problems:
> - kimgio backend advertised eps support, but it doesn't really support it
> - txt backend had the same priority as spectre, and sort() happened to put them in the wrong order
> 
> 
> Diffs
> -----
> 
>   generators/kimgio/libokularGenerator_kimgio.json e109268 
>   generators/kimgio/okularApplication_kimgio.desktop db893ed 
>   generators/kimgio/okularKimgio.desktop 983c300 
>   generators/kimgio/org.kde.mobile.okular_kimgio.desktop 14ffe30 
>   generators/kimgio/org.kde.okular-kimgio.metainfo.xml a0aa40a 
>   generators/txt/libokularGenerator_txt.json 97325db 
> 
> Diff: https://git.reviewboard.kde.org/r/129584/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20161208/6f96c33e/attachment.html>