Review Request 129610: Check all supported mime types the generator supports

Miklós Máté mtmkls at gmail.com
Thu Dec 8 21:43:58 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129610/
-----------------------------------------------------------

(Updated Dec. 8, 2016, 9:43 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Changes
-------

Submitted with commit e81fb3d639400df03d47749e4c5532b32394b45c by Albert Astals Cid on behalf of Miklós Máté to branch Applications/16.12.


Repository: okular


Description
-------

Stopping on the first inherit match can prevent finding a perfect match, and thus we might enter a competition of inherit matches from other generators.

Example: spectre supports application/postscript and image/x-eps. When opening an eps the app/ps is an inherit match, but so is text/plain from the txt generator. Thanks to stable_sort() the txt generator is deterministically selected from the above two inherit matches. Unless we continue and find the perfect match, which is spectre:image/x-eps.


Diffs
-----

  core/document.cpp ff9253a 

Diff: https://git.reviewboard.kde.org/r/129610/diff/


Testing
-------


Thanks,

Miklós Máté

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20161208/1f56b2da/attachment.html>


More information about the Okular-devel mailing list