[Okular-devel] Review Request 126406: Okular should warn if closing with multiple tabs opened

[torham zed]

> On Feb. 19, 2016, 12:25 a.m., Albert Astals Cid wrote:
> > home/user/projects/OkularOriginal/shell/shell.cpp, line 495
> > <https://git.reviewboard.kde.org/r/126406/diff/3/?file=441914#file441914line495>
> >
> >     Please use the static functions of KMessageBox, probably questionYesNo ?
> 
> torham zed wrote:
>     I apologize, I do not know what that means.  If (for example) you mean how KMessageBox is used in Okular/ui/searchlineedit.cpp line 258?
>     
>     In searching the web, I found this:  http://api.kde.org/frameworks-api/frameworks5-apidocs/kwidgetsaddons/html/namespaceKMessageBox.html
>     
>     It is not readily apparent to me how best to proceed, plus this is docs for QT5.  I'll look for you in IRC for more guidance.

Wanted to bring this back up to the top of the list for further review.


- torham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126406/#review92545
-----------------------------------------------------------


On June 1, 2016, 12:08 a.m., torham zed wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126406/
> -----------------------------------------------------------
> 
> (Updated June 1, 2016, 12:08 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 334019
>     http://bugs.kde.org/show_bug.cgi?id=334019
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Multi tab popup warning
> 
> 
> Diffs
> -----
> 
>   home/user/projects/OkularOriginal/shell/shell.cpp d80def4 
> 
> Diff: https://git.reviewboard.kde.org/r/126406/diff/
> 
> 
> Testing
> -------
> 
> Opened several pdf files, closed entire program with multiple files open to see if popup properly functions along with the 'yes' and 'no' buttons.
> 
> 
> Thanks,
> 
> torham zed
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160801/bd6a31f4/attachment.html>