[Okular-devel] Review Request 127654: Avoid potential crash when painting

[Dan Leinir Turthra Jensen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127654/
-----------------------------------------------------------

(Updated April 21, 2016, 2 p.m.)


Status
------

This change has been discarded.


Review request for Okular.


Repository: okular


Description
-------

>From time to time the previous version of this code can trigger a crash. With the guard in place, the crash no longer occurs. In particular, the crash occurs when switching away from full screen in Peruse on Windows, and seems to be related to resizing and painting happening roughly at the same time.


Diffs
-----

  ui/pagepainter.cpp 2a3cdcc 

Diff: https://git.reviewboard.kde.org/r/127654/diff/


Testing
-------

Spamming full-screen/unfull-screen switching when having a pdf loaded in peruse on windows, crash happened without this guard in place, with the guard in place the crash no longer occurs.


Thanks,

Dan Leinir Turthra Jensen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160421/131ae3fa/attachment.html>