[Okular-devel] Review Request 127636: Display (and partly allow editing) annotation revisions

[Jonathan Verner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127636/
-----------------------------------------------------------

(Updated April 11, 2016, 8:32 p.m.)


Review request for Okular.


Repository: okular


Description
-------

When an annotation has revisions, display them in the 
popup window and allow the user to edit their contents.

This is just a first step towards a better review workflow.
What remains to be done:

  - hide the revision annotations (the revisions should only
    be shown in the popup they are revisions of; not separately
    because this may lead to e.g. overlapping icons when an annotation
    and its revision have the same position on the page); this would
    conform to the spec, see e.g. the comments to the R key in
    table 8.21 on p. 620 of the 1.7 revision of the spec)

  - allow setting the revision status (i.e. Accepted/Rejected/Canceled/Completed/None; 
    Marked/Unmarked; see pdf spec table 8.22 on p. 620 of 1.7 revision of the spec)
    
  - allow adding revisions; this will need changes to poppler
    as it currently does not allow setting the IRT key; I am working
    on a patch and I will post it to the poppler mailing list when I 
    am satisfied with it


Diffs
-----

  core/document.h 63f58741bd6680a673945a7b7c05a10130968beb 
  core/document.cpp 6953b1fb0dc29a375be7ff331a2a2bccce975366 
  generators/poppler/generator_pdf.cpp a65487af06a221cf7faf72e108aa1f04e1b91b04 
  ui/annotwindow.h 579f3d33514ec95647ce1e03f0f4c08d6d828dba 
  ui/annotwindow.cpp 6677c6fc9d7cb7e9a2ae119a532925d5ccc1216c 

Diff: https://git.reviewboard.kde.org/r/127636/diff/


Testing
-------

Opened a file with annotation revisions and tested that they can be edited and properly saved back.


File Attachments (updated)
----------------

Test file with annotation revisions.
  https://git.reviewboard.kde.org/media/uploaded/files/2016/04/11/2f84d42c-e317-4d3e-968b-8b873945d51a__test.pdf


Thanks,

Jonathan Verner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160411/c4f1bf5e/attachment.html>