[Okular-devel] Review Request 127541: Add support for importing annotations from another document.

[Jonathan Verner]

> On April 4, 2016, 10:26 p.m., Albert Astals Cid wrote:
> > The implementation seems ok-ish from a quick look, but is this something that really makes sense? Do you see more people other than you having a need for this this feature?

I think it does, but of course, that is my biased opinion :-) I can at least describe the usecases I have in mind (also included in the wishlist): if there are several people commenting on a draft the author would then like to merge their comments into a single file. Another usecase I came across was when I was reviewing a paper on two different computers and forgot to sync the files. I ended up with two sets of comments which I wanted to merge into a single file. I think both Acrobat and Foxit Reader have this option under windows (I found it in their documentation when googling for this feature but I don't have a windows computer handy to test it). On the other hand it sure does not need to feature so prominently in the file menu. Perhaps it would better fit into the Tools or Edit menus?


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127541/#review94259
-----------------------------------------------------------


On April 5, 2016, 7:07 a.m., Jonathan Verner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127541/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 7:07 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 361292
>     http://bugs.kde.org/show_bug.cgi?id=361292
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> This patch allows the user to import annotations from a different document into the currently opened document.
> While importing, it tries to avoid adding duplicate annotations by looking whether an annotation with 
> the same uniqueName is not already present on the given page. It doesn't check whether the currently opened
> document corresponds to the one where comments are imported from. It just loops over the pages starting
> from 0 to the minimum of the size of the two files and for each page it imports the annotations.
> 
> 
> Diffs
> -----
> 
>   core/document.h 63f58741bd6680a673945a7b7c05a10130968beb 
>   core/document.cpp 6953b1fb0dc29a375be7ff331a2a2bccce975366 
>   kdocumentviewer.h f99c69ef4ac8dbfb7ee600df7f97db7c62a409ab 
>   part.h 44d032e496aacde0b8c239ed344a0f3eb39fa09b 
>   part.cpp d8f1750f33a903c1734857042b601b52d8d8e1f2 
>   shell/shell.h fea80acfbf91968d90babd281d199341b6370bbd 
>   shell/shell.cpp d80def41c2c17364557402654205a5c705a29d1f 
>   shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 
>   tests/data/annots.pdf PRE-CREATION 
>   tests/mainshelltest.cpp a044895c1935c587552e875a98627e58d19ed443 
> 
> Diff: https://git.reviewboard.kde.org/r/127541/diff/
> 
> 
> Testing
> -------
> 
> Tested both manually on several files and also provided a simple automatic test in mainshelltest.cpp.
> 
> 
> Thanks,
> 
> Jonathan Verner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160405/548c272e/attachment-0001.html>