[Okular-devel] Review Request 125313: Presentation: don't darken the image in the middle of the fade transition

[Arseniy Lartsev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125313/
-----------------------------------------------------------

(Updated Sept. 27, 2015, 7:38 p.m.)


Review request for Okular.


Bugs: 352877
    http://bugs.kde.org/show_bug.cgi?id=352877


Repository: okular


Description
-------

Right in the middle of the fade transition, the previous and the next slide are painted each with 50% opacity on top of black background. This means that the black background will be slightly visible through the slides, which it shouldn't be. I propose a patch to fix this.


Diffs
-----

  ui/presentationwidget.cpp 0d9a55d 

Diff: https://git.reviewboard.kde.org/r/125313/diff/


Testing
-------

Works for me.


File Attachments (updated)
----------------

Test case (two blank pages, 0.5s long fade transition)
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/27/7df41157-5884-4a29-b3ea-f3590b7bf831__blank_transition.pdf


Thanks,

Arseniy Lartsev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150927/22eca6c4/attachment.html>