[Okular-devel] Review Request 125020: okular: Add zip/x-rar mimetype to .desktop files

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125020/#review85517
-----------------------------------------------------------


Actually, if you just leave the libokularGenerator_comicbook.desktop change this should be ok, tells okular this plugin may know how to open rar files, so if you use the file dialog or the command line it should work, but it doesn't tell the rest of the world so dolphin et al won't suggest okular to open random .rar files.  I think this should be a good enough compromise, can you check what i am saying is actually true?

- Albert Astals Cid


On set. 1, 2015, 4:02 p.m., Boris Egorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125020/
> -----------------------------------------------------------
> 
> (Updated set. 1, 2015, 4:02 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 343645
>     http://bugs.kde.org/show_bug.cgi?id=343645
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Adds ability to open rar/zip archives with images in okular
> 
> 
> Diffs
> -----
> 
>   generators/comicbook/libokularGenerator_comicbook.desktop 5a91a5f 
>   generators/comicbook/okularApplication_comicbook.desktop dee494b 
>   generators/comicbook/okularComicbook.desktop 1dded78 
> 
> Diff: https://git.reviewboard.kde.org/r/125020/diff/
> 
> 
> Testing
> -------
> 
> Build; open some archives in okular.
> 
> 
> Thanks,
> 
> Boris Egorov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150916/dfbbf5b6/attachment.html>