[Okular-devel] Review Request 124964: Ensure pixmap of proper resolution used when switching viewmode

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124964/#review85407
-----------------------------------------------------------


Could you update the patch? It doesn't seem to apply cleanly against master anymore

- Albert Astals Cid


On set. 1, 2015, 7:12 a.m., Jake  Linder wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124964/
> -----------------------------------------------------------
> 
> (Updated set. 1, 2015, 7:12 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 351889
>     http://bugs.kde.org/show_bug.cgi?id=351889
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Ensure pixmap of proper resolution used when switching viewmode / rotating view
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 27a88ddfec18d9259e669eb2ab7b60ef03e2af75 
>   conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 
>   core/document.cpp 85fe007866e77bc99ac0746a6c53b5c92ab73f67 
>   part-viewermode.rc bccd4912fcc11d9f091cbab2b056f3fbf5bf5cf7 
>   part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 
>   ui/pageview.h e65b57500d12ae2d8c5286e6542504e17813668c 
>   ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 
> 
> Diff: https://git.reviewboard.kde.org/r/124964/diff/
> 
> 
> Testing
> -------
> 
> Steps to repro (viewmode):
> 1) resize app window to be narrow enough so that in facing pages viewmode 
> page dimensions are reduced.
> 2) switch to facing pages mode.
> 3) switch back to single page mode.
> 
> Steps to repro (rotation):
> 1) open a pdf with protrait mode paper dimensions.
> 2) rotate the view clockwise.
> 3) rotate the view back to original orientation.
> 
> Expected Result:
> Single page is shown at proper resolution
> 
> Actual Result:
> Single page is displayed with proper dimensions but is actually a scaled-up 
> version of a lower resolution pixmap.
> 
> I've verified that this fixes the issue.
> 
> Note that adding this line after slotRelayoutPages() is sprinkled
> all over pageview.cpp, always affixed with a "we may not need to do this" - Code Smell.
> 
> 
> Thanks,
> 
> Jake  Linder
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150914/57d76dce/attachment.html>