[Okular-devel] Review Request 125742: Fix okularplugin linking on VS 2015.

[Gleb Popov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125742/
-----------------------------------------------------------

(Updated Oct. 29, 2015, 5:09 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Changes
-------

Submitted with commit c339bc5d0a28d21990ea4eb876703ddc8217a22f by Gleb Popov to branch frameworks.


Repository: okular


Description
-------

okularplugin target from mobile/components suffers from the same problem as okularpart in https://git.reviewboard.kde.org/r/125741/ 
But the cause is a bit different now. okularplugin uses settings.cpp generated by KConfig and its header declares Settings class with OKULARPART_EXPORT. For okularplugin target this macro gets expanded to __declspec(dllimport) and it makes linker to look for Settings class symbols in okularcore.

Fix this by tricking VS that we are building okularpart target.


Diffs
-----

  mobile/components/CMakeLists.txt a5db04e8e40631452adfee3ed41083724356c6c5 

Diff: https://git.reviewboard.kde.org/r/125742/diff/


Testing
-------


Thanks,

Gleb Popov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151029/8abd3d9c/attachment.html>