[Okular-devel] Review Request 125741: okular: Fix linking with MSVC 2015.

[Gleb Popov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125741/
-----------------------------------------------------------

(Updated Oct. 29, 2015, 5:09 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Changes
-------

Submitted with commit 6fdc6e22a955d160690ed9ebd0230d0247bef9a5 by Gleb Popov to branch frameworks.


Repository: okular


Description
-------

okular/part.cpp includes interfaces/viewerinterface.h and its OKULARCORE_EXPORT macro gets expanded into __declspec(dllimport). This makes VS linker to drop ViewerInterface::~ViewerInterface() definition and to look for it in KF5OkularCore.dll. But this include is never used anywhere in okularcore, hence missing symbol.

Including interfaces/viewerinterface.h in any of okularcore sources fixes the problem.


Diffs
-----

  interfaces/viewerinterface.h 4f27921 

Diff: https://git.reviewboard.kde.org/r/125741/diff/


Testing
-------


Thanks,

Gleb Popov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151029/b8f2f3bb/attachment-0001.html>