[Okular-devel] Review Request 125801: Make inline annotation border width customizable

[Sumit Sahrawat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125801/
-----------------------------------------------------------

(Updated Oct. 29, 2015, 3:39 p.m.)


Review request for Okular and Albert Astals Cid.


Changes
-------

I updated the patch. I was able to make it work on non-PDF documents, which I tested on jpg and epub files.
I got okular to save the property when edited for the default annotation, but it does not get used for new widgets, maybe I'm missing something here?

Thanks :)


Bugs: 332887
    http://bugs.kde.org/show_bug.cgi?id=332887


Repository: okular


Description
-------

Make inline annotation border width customizable, using a spin widget to accept input


Diffs (updated)
-----

  conf/widgetannottools.cpp 6d05eed 
  ui/annotationwidgets.h 6e7a218 
  ui/annotationwidgets.cpp 450e50b 
  ui/pagepainter.cpp 6eed5b6 

Diff: https://git.reviewboard.kde.org/r/125801/diff/


Testing
-------

Saved a document with various widths for border from 0 to more.

Opened it in okular itself, and it worked.
The unpatched version of okular also works fine, and uses the same width as set using the patched version.

Other pdf readers on linux (`evince`, `zathura`, `acroread-9.5.5`), do not display any annotations. No matter which okular (patched or unpatched) is used to create them.


Thanks,

Sumit Sahrawat

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151029/fb068c9b/attachment.html>